chore: fix for jetbrains gateway agent_id issue #437
Conversation
rowansmithau
added
the
version:patch
rowansmithau
changed the title
There was a problem hiding this comment.
Just to reiterate what I mentioned in Slack, IMO we should remove the agent_id query param, it will never work, and replace it with agent, or in other words make this fix again: coder/modules@3878e66
Plus delete the (unused). Will be removed in a future version part of the name description.
|
@rowansmithau LGTM can you do a patch version bump on this again since it was updated to 1.2.3 in #440 |
|
Do we have a way to communicate potentially breaking changes in modules? My guess is, even though this is technically a breaking change, it should never have worked for users anyway, so it may not be necessary to classify it as such, but if we do have a method for that (changelog or something), we might as well throw a note in there. Edit: for visibility, we discussed on Slack and ended up going back to the initial idea of dropping |
|
@code-asher We can bump the major version if we are removing an input. Here we are just fixing something internally, so it's fine to do a patch here. |
rowansmithau
deleted the
rowansmithau/chore/jetbrains_gateway_multi_agent_fix
branch
Description
Fixes a regression added in #167 which implemented support for multiple agents by appending the agent id to the URI, however in a single agent environment it results in the agent id from the template apply (on upload to Coder from client) being injected, and when a workspace is later built using the template the agent id is no longer correct.
Resolves the error
The workspace “<name>” does not have an agent with ID “<id>”being thrown by Jetbrains Gateway app upon attempting to open a Jetbrains app from within a Coder workspace.When wishing to target a specific Coder Agent with the Jetbrains Gateway module one should use the
agent_namevariable in the module configuration to specify the desired agent name. This will append the agent name to the URI.Type of Change
Module Information
Path:
registry/coder/modules/jetbrains-gatewayNew version:
v1.2.4Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
Reported by customer on Zendesk ticket 4391